Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix top await in examples #206

Merged
merged 1 commit into from
Feb 7, 2025
Merged

fix: fix top await in examples #206

merged 1 commit into from
Feb 7, 2025

Conversation

ruixingshi
Copy link
Contributor

@ruixingshi ruixingshi commented Feb 7, 2025 •
edited
Loading

Fix top-level await issue: All examples use proper async/await patterns wrapped in functions with error handling.

After the fix, I can run the case in the example:
image

related issue: issue 205

@ruixingshi ruixingshi mentioned this pull request Feb 7, 2025
Closed
BruceMacD
BruceMacD approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry you hit this problem, I appreciate that you came through and fixed the examples when you figured it out.

@BruceMacD BruceMacD merged commit 9320655 into ollama:main Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BruceMacD BruceMacD BruceMacD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixingshi @BruceMacD